Skip to content

gh-139819: rlcompleter – avoid suggesting attributes not accessible on instances #139820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

gh-139819: rlcompleter – avoid suggesting attributes not accessible on instances #139820

wants to merge 8 commits into from
+31 −8

Conversation

ttw225
Copy link
Contributor

@ttw225 ttw225 commented Oct 9, 2025 •
edited
Loading

Fix tab-completion suggesting names that are not accessible on instances
(e.g., Enum members showing __name__).

Change

In rlcompleter.attr_matches(), when getattr(thisobject, word, None)
is None, only add the candidate if hasattr(thisobject, word) is true.

Effect

Removes bogus suggestions without affecting valid completions.

Bogus suggestions

['Color.BLUE.__iter__',
 'Color.BLUE.__getitem__',
 'Color.BLUE.__members__',
 'Color.BLUE.__contains__',
 'Color.BLUE.__qualname__',
 'Color.BLUE.__len__',
 'Color.BLUE.__name__']
# Additionally seen among bogus suggestions:
'Enum.__abstractmethods__'

@bedevere-app bedevere-app bot mentioned this pull request Oct 9, 2025
Open
@ttw225
Copy link
Contributor Author

ttw225 commented Oct 9, 2025

Noted the CI Test failure. I’m working on a fix and will push soon.

@ttw225
Copy link
Contributor Author

ttw225 commented Oct 9, 2025

Tests have passed. Thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ttw225